Fixed JAXRS contract trying to modify unmodified template queries and headers#893
Closed
bwangfdu wants to merge 6 commits into
Closed
Fixed JAXRS contract trying to modify unmodified template queries and headers#893bwangfdu wants to merge 6 commits into
bwangfdu wants to merge 6 commits into
Conversation
…ent build fail Fix OpenFeign#891
Fix JAXRS contract on API with @HeaderParam and @QueryParam feign cli…
Fix build error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request create a new ArrayList when trying to add new element into the template's queries and headers when dealing with the parameters in API. This bug is reported in #891 .
Beside this, it also overwrite the class and method level annotations to generate Accept and Content-Type named header with parameter with the same name, which I mentioned in #890.