Skip to content

Fixes an issue with http-headers duplication when using RequestTemplate#832

Merged
velo merged 2 commits into
OpenFeign:masterfrom
tworogue:case-insensitive-header-field-names
Nov 8, 2018
Merged

Fixes an issue with http-headers duplication when using RequestTemplate#832
velo merged 2 commits into
OpenFeign:masterfrom
tworogue:case-insensitive-header-field-names

Conversation

@tworogue
Copy link
Copy Markdown
Contributor

@tworogue tworogue commented Nov 3, 2018

Hello,

Here're my changes with intention to complete the issue: #570

Also, it's my first open-source PR, so please be kind to describe my faults, in case they are.

Fixes #570

@tworogue tworogue closed this Nov 3, 2018
@tworogue tworogue deleted the case-insensitive-header-field-names branch November 3, 2018 14:25
@tworogue tworogue restored the case-insensitive-header-field-names branch November 3, 2018 14:31
@tworogue tworogue reopened this Nov 3, 2018
velo
velo approved these changes Nov 4, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@velo velo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense #570

LGTM, just need to have travis build passing

@velo velo added bug Unexpected or incorrect behavior enhancement For recommending new capabilities waiting for feedback Issues waiting for a response from either to the author or other maintainers ready to merge Will be merged if no other member ask for changes labels Nov 4, 2018
@kdavisk6
Copy link
Copy Markdown
Member

kdavisk6 commented Nov 4, 2018

Travis is unhappy with the formatting on the files, please run mvn clean install and push the formatting changes.

kdavisk6
kdavisk6 requested changes Nov 4, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@kdavisk6 kdavisk6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tworogue Can you please update the formatting and address my feedback.

Comment thread core/src/test/java/feign/LoggerTest.java
@velo velo removed the waiting for feedback Issues waiting for a response from either to the author or other maintainers label Nov 4, 2018
@velo
Copy link
Copy Markdown
Member

velo commented Nov 4, 2018

@kdavisk6 I think we are good to go, any other comments?

@velo velo merged commit cb036e4 into OpenFeign:master Nov 8, 2018
velo pushed a commit that referenced this pull request Oct 7, 2024
@tworogue @velo
Fixes an issue with http-headers duplication when using RequestTempla…
77a6778 
…te (#832)

* Fixes an issue with http-headers duplication when using RequestTemplate

Fixes #570

* Changes imports formatting (upon running 'clean install')
velo pushed a commit that referenced this pull request Oct 8, 2024
@tworogue @velo
Fixes an issue with http-headers duplication when using RequestTempla…
c2ec248 
…te (#832)

* Fixes an issue with http-headers duplication when using RequestTemplate

Fixes #570

* Changes imports formatting (upon running 'clean install')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@velo velo velo approved these changes

@kdavisk6 kdavisk6 kdavisk6 approved these changes

Assignees

No one assigned

Labels

bug Unexpected or incorrect behavior enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tworogue @kdavisk6 @velo