Skip to content

Return null (empty target object) if status code is 204 #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdavisk6 merged 1 commit into from
Sep 24, 2018
Merged

Return null (empty target object) if status code is 204 #792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jaxb/src/main/java/feign/jaxb/JAXBDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private JAXBDecoder(Builder builder) {

@Override
public Object decode(Response response, Type type) throws IOException {
if (response.status() == 404)
if (response.status() == 404 || response.status() == 204)

@velo velo Sep 20, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fair.

Could you just add a test for 204 as well?

@kdavisk6 kdavisk6 Sep 21, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this globally or just in this decoder? @velo?

@kdavisk6 kdavisk6 Sep 21, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better yet, we should inspect the body before sending it to the Decoder here:

feign/core/src/main/java/feign/SynchronousMethodHandler.java

Lines 162 to 170 in d7cc9b6

Object decode(Response response) throws Throwable {
try {
return decoder.decode(response, metadata.returnType());
} catch (FeignException e) {
throw e;
} catch (RuntimeException e) {
throw new DecodeException(e.getMessage(), e);
}
}

@selimok selimok Sep 23, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer a global way to handle it.

@velo velo Sep 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this globally or just in this decoder?

@kdavisk6 we could, but that would break current API for all decoders...

If you think of a OptionalDecoder the result for a 204 or 404 is Optional.empty()

For a JAXB decoder null
For a List decoder may be Collections.emptyList() (which I currently use for a binary format decoder.

So, although I would like to see this in a single location, I don't think we can.

@kdavisk6 kdavisk6 Sep 24, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Let's go with this for now and keep an eye out for other issues.

return Util.emptyValueOf(type);
if (response.body() == null)
return null;
Expand Down