Skip to content

@Path("") annotations are equivalent to @Path("/") - #631

Merged
velo merged 1 commit into
OpenFeign:masterfrom
carterkozak:empty_path
Apr 1, 2018
Merged

@Path("") annotations are equivalent to @Path("/")#631
velo merged 1 commit into
OpenFeign:masterfrom
carterkozak:empty_path

Conversation

@carterkozak

Copy link
Copy Markdown

The documentation suggests that all paths are relative:
https://docs.oracle.com/javaee/6/api/javax/ws/rs/Path.html

@carterkozak

Copy link
Copy Markdown
Author

This change resolves #630

@kdavisk6

Copy link
Copy Markdown
Member

This looks good to me. I suggest adding some changes to the documentation as well. Right now the README calls this situation out explicitly as something that will throw an IllegalStateException. See JAXRS Readme

@carterkozak

Copy link
Copy Markdown
Author

Great catch @kdavisk6, thanks! Fixed.

@kdavisk6

Copy link
Copy Markdown
Member

Approved from my point of view. @velo any additional feedback?

@velo

velo commented Mar 30, 2018

Copy link
Copy Markdown
Member

Nop, good to go

@velo
velo merged commit 524c0d9 into OpenFeign:master Apr 1, 2018
velo pushed a commit that referenced this pull request Oct 7, 2024
velo pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants