Perform type validation for QueryMap and HeaderMap in Contract#573
Conversation
|
#567 concluded that more checks should be done upfront in the Contract. This PR aims to perform both the Map validation AND the Map's String key validation in the contract. This reduces the number of checks that happen at "runtime" within the ReflectiveFeign class |
08b414d to
3016dd3
Compare
3016dd3 to
45139d0
Compare
|
This change breaks clients which use a method parameter as HeaderMap which is non-generic (like Spring's HttpHeaders). The following used to work before the PR (when using spring-cloud-openfeign): @RequestMapping(method = RequestMethod.POST, path = "/path")
void method(@RequestHeader HttpHeaders headers);It now fails with As a workaround |
|
I must have missed that PR looking for fixes. Thanks for the quick feedback. |
No description provided.