Add the Content-Type if specified, unless we are setting the body#569
Merged
Conversation
Contributor
Author
|
@adriancole Is there any chance this might be approved? |
|
SGTM Add to CHANGES file for the next minor version? |
Contributor
Author
|
@adriancole done. Thanks! |
Contributor
Author
|
@adriancole when are you planning the next release? |
Contributor
Author
|
@adriancole Is there something I need to do to get this released? |
phymbert
pushed a commit
to phymbert/feign
that referenced
this pull request
Aug 22, 2017
…enFeign#569) * Add the Content-Type if specified, unless we are setting the body * Update changelog
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Add the Content-Type if specified, unless we are setting the body * Update changelog
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Add the Content-Type if specified, unless we are setting the body * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #391
If we specify the Content-Type we should send it, even without a body.
The Apache client does the same.
https://github.com/OpenFeign/feign/blob/release-9.5.0/httpclient/src/main/java/feign/httpclient/ApacheHttpClient.java#L127-L129