introduce OptionalDecoder - #548
Merged
codefromthecrypt merged 7 commits intoMay 6, 2017
Merged
Conversation
| import java.lang.reflect.Type; | ||
| import java.util.Optional; | ||
|
|
||
| public class OptionalDecoder implements Decoder { |
codefromthecrypt
left a comment
There was a problem hiding this comment.
should this be feign-java8?
| final Decoder delegate; | ||
|
|
||
| public OptionalDecoder(Decoder delegate) { | ||
| this.delegate = delegate; |
…onalAwareDecoder-in-feign
Contributor
Author
|
@adriancole done! |
Contributor
|
I like |
Contributor
Author
|
Naming it as feign-java8 will imply that further features around java8 will have to be shipped in this artefact, so for instance if one just wants to use Optional stuff, will bring the whole java8 support. If that's ok, I don't mind renaming it |
|
If we were to do other things in java 8, each would be a different
component, which could be configured separately. I wouldnt worry about this.
…On 1 May 2017 9:56 pm, "Ariel" ***@***.***> wrote:
Naming it as feign-java8 will imply that further features around java8
will have to be shipped in this artefact, so for instance if one just wants
to use Optional stuff, will bring the whole java8 support.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#548 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD612kZv5Tl06B23giVxSKU8E9bEvEYks5r1eR3gaJpZM4Mw93c>
.
|
Contributor
Author
|
Fair enough 👍 |
|
if you can rejig in the next couple days, will go in the next release. Don't forget CHANGES file |
Contributor
Author
|
@adriancole Done! |
|
mind renaming the dir to java8 (pom artifact is good, just this is more conventional with others) |
Contributor
Author
|
@adriancole renamed |
phymbert
pushed a commit
to phymbert/feign
that referenced
this pull request
Aug 22, 2017
Introduces `feign-java8` with support for `java.util.Optional`
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
Introduces `feign-java8` with support for `java.util.Optional`
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Introduces `feign-java8` with support for `java.util.Optional`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #294