Set empty HttpEntity if request body is null.#511
Closed
Infeligo wants to merge 1 commit into
Closed
Conversation
Otherwise RequestBuilder will create HttpEntity from query parameters.
Contributor
|
restarting build |
|
test? |
|
closing until interest resumes (specifically adding a test) |
jonfreedman
added a commit
to jonfreedman/feign
that referenced
this pull request
May 9, 2017
Contributor
|
I've created a failing test, I introduced a test scope dependency on feign-jaxrs from feign-httpclient as that's specifically how we're using this, you may be able to re-write the test to simplify it. Github's links are are a bit confused, here's the PR: #557 |
|
thanks! closed via 431b328 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue I raised in #510 where Feign did not account for Apache HttpClient behaviour difference in case
HttpEntitywas not set at all (e.g. due to null body in this case). This resulted inRequestBuildercreatingHttpEntityfrom query parameters.