Upgrade to OkHttp 3.2 and adjust tests to work with new version#390
Conversation
…ttpClient and MockWebServer methods
| @@ -1,3 +1,6 @@ | |||
| ### Version 8.18 | |||
There was a problem hiding this comment.
8.17 hasn't been cut, yet, so you can put this there
|
LGTM, just nit on changelog. Thanks for taking time to do this! |
|
No problem! Feign is a huge help to us in a project we're working on at UW-Madison. |
|
Thanks for this update! |
|
@adriancole Any idea when you'll do the next release that includes this PR? |
|
Thanks for asking! v8.17.0 is on the way
|
|
We've got a whole load of diamond dependencies with Feign and feign-okhttp, and this makes Feign 8.17.0 binary-incompatible with 8.16.0. This is causing us plenty of grief. Since okhttp3 uses a different package name and so peacefully coexists with okhttp2, any chance we could create a feign-okhttp3 project, put the results of this PR in there, keep the old code in here, and publish an 8.18.0 which reverts the breaking change to feign-okhttp? If this sounds like an appropriate course of action, I'd be happy to contribute it. |
|
@j-baker right. go for it! |
Upgrade to OkHttp 3.2 and adjust tests to work with new version
Upgrading to OkHttp3 will allow applications with Netflix-Feign to use enhanced OkHttpClient capabilities, especially the newly introduced Builder method.
In addition to import and compile statement changes, method name changes were needed in multiple tests to work with the new dependency version. In the OkHttpClient class, clone() was replaced with newBuilder() as a way to change client settings.