Added rx.Completable support#387
Merged
Merged
Conversation
|
NetflixOSS » feign » feign-pull-requests #283 FAILURE |
|
nice work. maybe add to CHANGES for 8.17? |
|
NetflixOSS » feign » feign-pull-requests #284 FAILURE |
b39b4c5 to
be8e8cd
Compare
Contributor
Author
|
Thank you, done. Tell me if anything more is needed :) |
|
NetflixOSS » feign » feign-pull-requests #285 FAILURE |
be8e8cd to
53cfd0d
Compare
|
NetflixOSS » feign » feign-pull-requests #286 FAILURE |
|
nope. all good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rx.CompletablesupportCompletablein theory it can be upgraded to 1.5.x as it should be backward compatible.Fixes #379