Flatten feign-bom so imports do not override consumer dependency management - #3508
Open
kalayciburak wants to merge 1 commit into
Open
Flatten feign-bom so imports do not override consumer dependency management#3508kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
…gement Installing and deploying feign-bom previously published a POM that still parented feign-parent. Importing that BOM into a project such as Spring Boot also imported parent dependencyManagement (for example jackson-bom) and overrode the consumer's managed versions. Apply flatten-maven-plugin in bom mode on the BOM module and template so the published artifact only manages Feign modules. Fixes OpenFeign#3505
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Importing
feign-bominto a consumer that already manages versions (for example Spring Boot) previously pulledfeign-parentdependency management through the published BOM parent. That overrode consumer-managed artifacts such as Jackson.This applies
flatten-maven-plugininbommode on the committedfeign-bommodule and the sundr BOM template so the installed/deployed POM only manages Feign modules.Fixes #3505
Verification
./mvnw -N -Pquickbuild install./mvnw -pl feign-bom -Pquickbuild installfeign-bomPOM has no<parent>and no third-partydependencyManagemententriesspring-boot-starter-parent3.5.4:jackson-core2.19.2feign-bom13.13:jackson-core2.22.0 (override bug)feign-bom13.14-SNAPSHOT:jackson-core2.19.2 (Boot version kept)