treat invalid expression value modifier as a literal#3437
Merged
Conversation
velo
approved these changes
Jun 23, 2026
velo
left a comment
Member
There was a problem hiding this comment.
This keeps the parser behavior nicely contained: invalid regex modifiers now fall back to the existing literal path, and the tests cover both header-map expansion and valid modifiers. Looks good to me.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Values supplied through
@HeaderMapare parsed as URI templates, so a value that contains{...:...}is treated as an expression and the text after the:is compiled as a regular expression inExpression. A value like{range:[1:10}(brackets plus a colon, easy to hit with JSON-ish header data) is not a valid pattern, soPattern.compilethrows an uncaughtPatternSyntaxExceptionfromExpressions.createand the whole request fails to build. Reported in #2739.Expressions.createalready returnsnullfor chunks it cannot validate as an expression, andTemplate.parseFragmentkeeps those as literals. The fix catchesPatternSyntaxExceptionthere and falls back to that same literal path, so a malformed value modifier is emitted verbatim instead of aborting expansion. Keeping the guard in the parser covers every template type (header, query, uri) and leaves valid{name:regex}expressions untouched.