encode collection values in urlencoded form bodies#3436
Merged
Conversation
velo
approved these changes
Jun 23, 2026
velo
left a comment
Member
There was a problem hiding this comment.
Good catch on the collection-valued form path. Encoding the values before handing them to CollectionFormat matches the scalar behavior, and the array/collection regressions cover the failure mode clearly.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: post an
application/x-www-form-urlencodedform whose value is a collection or array, e.g. atagsfield of["a&b=c", "d"]. The body comes out astags=a&b=c&tags=d, smuggling an extrab=cfield into the request the downstream service parses.Cause:
UrlencodedFormContentProcessor.createKeyValuePaircollects collection and array values withObject::toStringand passes them toCollectionFormat.join, which encodes the field name and the separator but writes each value verbatim. The scalar path already runs values throughencode, so only collection-valued fields leak reserved characters.Fix: encode each collection value with the same
encode(value, charset)helper before the join, matching the scalar path.QueryTemplateis the only otherCollectionFormat.joincaller and already passes pre-encoded values, sojoinitself is left untouched. Added regression tests for the array and collection paths.