REFACTOR: remove helper field BaseBuilder#thisB#2783
Closed
hosuaby wants to merge 1 commit into
Closed
Conversation
velo
requested changes
Mar 3, 2025
velo
left a comment
Member
There was a problem hiding this comment.
I don't see the value of adding 20+ @SuppressWarnings
That was exactly the point of the 'thisB'
Feel free to reopen if you have a different idea without the extra warning suppression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In anticipation of conversation #2782
Remove the field
BaseBuilder#thisB. This field do not provide any value (appart of avoiding unchecked cast from builder methods), but it mixes badly withObject#cloneand creates bugs very difficult to spot.