Skip to content

added ErrorDecoder example with nested Decoder#195

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
molindo:github-error-example
Feb 25, 2015
Merged

added ErrorDecoder example with nested Decoder#195
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
molindo:github-error-example

Conversation

@sfussenegger

@sfussenegger sfussenegger commented Feb 23, 2015

Copy link
Copy Markdown
Contributor

as discussed in #194

@cloudbees-pull-request-builder

cloudbees-pull-request-builder commented Feb 23, 2015

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #65 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

cloudbees-pull-request-builder commented Feb 23, 2015

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #66 SUCCESS
This pull request looks good

codefromthecrypt
codefromthecrypt reviewed Feb 23, 2015
View reviewed changes
Comment thread example-github/src/main/java/feign/example/github/GitHubExample.java

@codefromthecrypt codefromthecrypt Feb 23, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be neat if this could extend RuntimeException, that would save some boilerplate in the example.. is that possible to make without gson getting complicated?

@sfussenegger sfussenegger Feb 24, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noto sure about gson. with jackson it would be just about annotating the constructor. but the JacksonDecoder needs some configuration as it won't use non-public fields by default.

@codefromthecrypt codefromthecrypt Feb 24, 2015 via email

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfussenegger sfussenegger Feb 24, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already had a quick shot at it without success. I haven't had the time to go into details though.

@codefromthecrypt

codefromthecrypt commented Feb 24, 2015

Copy link
Copy Markdown

Looks good. can you squash into a single commit with the following message

adds ErrorDecoder example with nested Decoder

I know.. added vs adds :)

Just that "this commit " + works better with that tense.

@sfussenegger

sfussenegger commented Feb 25, 2015

Copy link
Copy Markdown
Contributor Author

done

@cloudbees-pull-request-builder

cloudbees-pull-request-builder commented Feb 25, 2015

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #67 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Feb 25, 2015
@adriancole
Merge pull request #195 from molindo/github-error-example
cc3dd37 
added ErrorDecoder example with nested Decoder
@codefromthecrypt codefromthecrypt merged commit cc3dd37 into OpenFeign:master Feb 25, 2015
@codefromthecrypt

codefromthecrypt commented Feb 25, 2015

Copy link
Copy Markdown

Thanks!

@sfussenegger sfussenegger deleted the github-error-example branch February 23, 2016 10:16
velo pushed a commit that referenced this pull request Oct 8, 2024
@adriancole
Merge pull request #195 from molindo/github-error-example
e2133f7 
added ErrorDecoder example with nested Decoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfussenegger @cloudbees-pull-request-builder @codefromthecrypt