Skip to content

Use charset from response Content-Type header to decode #1302

Merged
kdavisk6 merged 6 commits into
OpenFeign:masterfrom
jaime-pineiro-imatia:master
Feb 3, 2021
Merged

Use charset from response Content-Type header to decode #1302
kdavisk6 merged 6 commits into
OpenFeign:masterfrom
jaime-pineiro-imatia:master

Conversation

@jaime-pineiro-imatia

Copy link
Copy Markdown
Contributor

Sometimes charset from response is not UTF-8, then if charset is informed in Content-type header, this charset is used to decode

Comment thread jackson/src/main/java/feign/jackson/JacksonDecoder.java Outdated
Comment thread jackson/src/main/java/feign/jackson/JacksonDecoder.java Outdated
@kdavisk6 kdavisk6 added the feedback provided Feedback has been provided to the author label Nov 3, 2020
@kdavisk6 kdavisk6 added ready to merge Will be merged if no other member ask for changes and removed feedback provided Feedback has been provided to the author labels Jan 8, 2021
@kdavisk6 kdavisk6 merged commit b79d6fc into OpenFeign:master Feb 3, 2021
velo pushed a commit that referenced this pull request Oct 7, 2024
* If charset is set in Content-type, we decode response using that charset

* Java 8 compatibility

* Format fix

* Moving code to get charset to Response in order to be used by another
decoders
velo pushed a commit that referenced this pull request Oct 8, 2024
* If charset is set in Content-type, we decode response using that charset

* Java 8 compatibility

* Format fix

* Moving code to get charset to Response in order to be used by another
decoders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Will be merged if no other member ask for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants