Skip to content

Make RibbonClient configurable with FeignBuilder#126

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
VanRoy:master
Dec 24, 2014
Merged

Make RibbonClient configurable with FeignBuilder#126
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
VanRoy:master

Conversation

@VanRoy

@VanRoy VanRoy commented Dec 1, 2014

Copy link
Copy Markdown
Contributor

This commit is related to #125

With this RibbonClient implementation it is possible to configure Ribbon with FeignBuilder.

@cloudbees-pull-request-builder

Copy link
Copy Markdown

feign-pull-requests #181 SUCCESS
This pull request looks good

@codefromthecrypt

Copy link
Copy Markdown

Hard for me to comment right now, but prefer making a static factory method
Client.Default.create() vs passing this stuff into ribbon.

More later cc @allenxwang

codefromthecrypt pushed a commit that referenced this pull request Dec 24, 2014
Make RibbonClient configurable with FeignBuilder
@codefromthecrypt codefromthecrypt merged commit 2c9b150 into OpenFeign:master Dec 24, 2014
velo pushed a commit that referenced this pull request Oct 8, 2024
Make RibbonClient configurable with FeignBuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants