decouple fallback from error handling#12
Merged
Merged
Conversation
…onses; decouple from error handling
|
feign-pull-requests #20 SUCCESS |
|
feign-pull-requests #21 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Jul 7, 2013
decouple fallback from error handling
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
decouple fallback from error handling
velo
pushed a commit
to hosuaby/feign
that referenced
this pull request
Nov 4, 2024
Update feign-vertx to be compatible with openfeign, java 11+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fallback handling is differs between sync and observer responses; decouple from error handling.
In an observer, there is no return type, rather a series of
onNext()calls. Conflating exception decoding with fallback makes it impossible to reliably reuse the ErrorDecoder class across both usage scenarios.