Use LinkedHashMap for deterministic iterations#1165
Merged
Conversation
3454156 to
04338e7
Compare
|
I guess to change implementation for tests is not a good approach. |
Contributor
Author
|
@kortov Thanks for the feedback. I guess another approach is to assert for both orders. It gets messy when there are more but in this test, there are only two possible cases. |
|
Maybe you're right with your implementation because in bindedLinkedHashMap . And more than that, your PR is to feign.mock package, so I guess performance is not bigger issue than determenistic results.
|
velo
approved these changes
Jan 29, 2020
velo
left a comment
Member
There was a problem hiding this comment.
Change looks good, will merge as soon build passes
04338e7 to
f67316d
Compare
Contributor
Author
|
@velo I fixed the format issue. |
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test
shouldPrintHeaders()asserts the string version ofRequestHeader.RequestHeaderclass uses a HashMap to store the headers. However, HashMap does not guarantee any specific order of entries. Test can fail if the iteration order changes.This PR proposes to fix the test by changing HashMap to LinkedHashMap that makes the iteration order deterministic.