ci: add windows-latest to e2e job#1237
Open
NikitaKorevo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't remove
process.env.PWD || process.env.INIT_CWD, part of testcd ./foo && npm run oa:generatewill fail for Windows.close #815, will be outdated
resolve #624, no
process.env.INIT_CWDno problemrelated with #690, was discussion about
cwdSummary by cubic
Add Windows to the E2E CI and make cwd detection OS-agnostic so generator tests run reliably on Windows. Fixes failures in the Windows path flow when running generation commands.
generator-cli: useprocess.cwd()only (dropPWD/INIT_CWD) to fix Windows path handling during commands likecd ./foo && npm run oa:generate.windows-latest; set Yarn bin to PATH; setOPENAPI_GENERATOR_CLI_SEARCH_URLvia$GITHUB_ENV; split test steps for cross-platform compatibility.Written for commit b12cda7. Summary will update on new commits.