Added consistant function names for BFS and DFS - #4
Merged
Conversation
Contributor
|
I second that. If the user wants to import both BFS and DFS in the same file they can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other search algorithms (Binary Search and Linear Search) search function is simply called
search. Breadth First Search (BFS) and Depth First Search (DFS) have the inconsistent namesbfsanddfsrespectively. I motion that these names are changed in favour of the simplersearch.It will not only make it easier for users (they won't have to look up every single search function's name), but also help easy development.