README as fragments#71
Conversation
|
@sbidoul final result seems weird, at least here on GH:
|
|
also, travis is red :) |
I indeed noticed the TOC bullet list does not look nice when DESCRIPTION.rst itself ends with a bullet list. I'll add a bold Table of contents line in the template as a separator. Travis is going to be just fine. For some reason it attempted to build a wrong branch. |
|
@simahawk if you have any other comment on the overall readme structure, shoot now :) |
|
Updated. See also OCA/maintainer-tools#343 |
|
About this, AFAIK @lmignon is also an active maintainer, isn't it? |
|
Very nice, thanks!
So I created #72 to be in line with the requirements :) |
|
Waiting for my question about maintainers before merging. |
|
@pedrobaeza it's obvious that guewen has the maintainer role here, that's why I proposed it as a way to kickstart the process of adding maintainers somewhere. If @guewen wants help and @lmignon wants to do it I'm fine with that of course, but that is up to them to coordinate and propose, as described in the maintainer role document. |
|
|
||
| (...) | ||
| [queue_job] | ||
| channels = root:4 |
There was a problem hiding this comment.
That's out of scope and not new, but the basic configuration shown here can block all the HTTP workers. I think we should put channels = root:2 or put more HTTP workers. (I can do it in a subsequent PR)
There was a problem hiding this comment.
Then it's good to change this at the same time I think
There was a problem hiding this comment.
Yes the queue_job documentation needs some love. I did not touch the content here.
There was a problem hiding this comment.
BTW with workers = 4 it would even be root:1, because one wkhtmlpdf report needs 2 workers so we need at least 3 free to generate a report and keep the UI working while the report runs.
There was a problem hiding this comment.
Right. I propose to merge this PR without any changes to the content.
There was a problem hiding this comment.
OK, merging now and waiting for later PRs for these considerations.
|
@sbidoul OK, I though this was the case for a shared maintainer role (and more as this module is huge). |
lmignon
left a comment
There was a problem hiding this comment.
Great!!!
@pedrobaeza I consider myself as a contributor and reviewer. Guewen is the maintainer.
|
BTW I prefer to have many maintainers very active on few modules each, rather than few maintainers risking burnout on many modules. We'll need to launch a campaign to have maintainers declare themselves. |
|
@sbidoul OK, let's try! On the code sprint we can also make a scan over repositories for this. |
|
Oops, forgot CONTRIBUTORS.rst, added at 0a9a13d |
Backport new README as fragments (#71)
Since the README had a minor glitch that blocked the pypi upload I take the opportunity to convert it to fragments.
More important (to be reviewed):