Skip to content

[IMP] avoid base_sparse_field --load#47

Merged
guewen merged 1 commit into
OCA:11.0from
simahawk:11-sparse_field-no-load
Jan 31, 2018
Merged

[IMP] avoid base_sparse_field --load#47
guewen merged 1 commit into
OCA:11.0from
simahawk:11-sparse_field-no-load

Conversation

@simahawk
Copy link
Copy Markdown
Contributor

base_sparse_field patches odoo fields
in order to be able to use fields.Serialized.

To "pay" this shortcut you have to load it at server load
which makes harder to test it with external tools (ie: pytest)
and disorient first users as they always miss this step.

Now we load the field straight from the module: easy, neat, works.

`base_sparse_field` patches odoo fields
in order to be able to use `fields.Serialized`.

To "pay" this shortcut you have to load it at server load
which makes harder to test it with external tools (ie: pytest)
and disorient first users as they always miss this step.

Now we load the field straight from the module: easy, neat, works.
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 26, 2018

Coverage Status

Coverage increased (+0.02%) to 78.301% when pulling 547538b on simahawk:11-sparse_field-no-load into e9da1b7 on OCA:11.0.

Copy link
Copy Markdown
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeaaah! 🎆

Thanks!

@simahawk
Copy link
Copy Markdown
Contributor Author

NOTE: runbot is yellow for:

2018-01-26 08:50:33,923 166 INFO openerp_test odoo.models: Storing computed values of queue.job.function.channel
<string>:98: (WARNING/2) Cannot analyze code. No Pygments lexer found for "none".
2018-01-26 08:50:35,029 166 WARNING openerp_test odoo.addons.base.module.module: docutils' system message present: <system_message level="2" line="98" source="<string>" type="WARNING"><paragraph>Cannot analyze code. No Pygments lexer found for "none".</paragraph><literal_block xml:space="preserve">.. code-block:: none

@guewen guewen merged commit ba5522f into OCA:11.0 Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants