Skip to content

Commit a160e8f

Browse files
defelmnqdefelmnq
authored
chore(coderd): remove the window option in open_in (coder#16104)
As we worked on adding a `open_in` parameter for workspace_apps - we initially created three options : - window - slim_window - tab After further investigation, `window` should not be used and has to be removed. ℹ️ I decided to remove the option instead of deprecating it as we've not created any release nor documented the feature. Can be discussed.
1 parent b4fde80 commit a160e8f

12 files changed

Lines changed: 27 additions & 41 deletions

File tree

‎coderd/apidoc/docs.go‎

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/apidoc/swagger.json‎

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/provisionerdserver/provisionerdserver.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2017,8 +2017,8 @@ func InsertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid.
20172017
switch app.OpenIn {
20182018
case sdkproto.AppOpenIn_TAB:
20192019
openIn = database.WorkspaceAppOpenInTab
2020-
case sdkproto.AppOpenIn_WINDOW:
2021-
openIn = database.WorkspaceAppOpenInWindow
2020+
case sdkproto.AppOpenIn_SLIM_WINDOW:
2021+
openIn = database.WorkspaceAppOpenInSlimWindow
20222022
}
20232023

20242024
dbApp, err := db.InsertWorkspaceApp(ctx, database.InsertWorkspaceAppParams{

‎codersdk/workspaceapps.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,11 @@ type WorkspaceAppOpenIn string
3838

3939
const (
4040
WorkspaceAppOpenInSlimWindow WorkspaceAppOpenIn = "slim-window"
41-
WorkspaceAppOpenInWindow WorkspaceAppOpenIn = "window"
4241
WorkspaceAppOpenInTab WorkspaceAppOpenIn = "tab"
4342
)
4443

4544
var MapWorkspaceAppOpenIns = map[WorkspaceAppOpenIn]struct{}{
4645
WorkspaceAppOpenInSlimWindow: {},
47-
WorkspaceAppOpenInWindow: {},
4846
WorkspaceAppOpenInTab: {},
4947
}
5048

‎docs/reference/api/builds.md‎

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/reference/api/schemas.md‎

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/reference/api/templates.md‎

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎provisioner/terraform/resources.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -437,8 +437,6 @@ func ConvertState(ctx context.Context, modules []*tfjson.StateModule, rawGraph s
437437
switch strings.ToLower(attrs.OpenIn) {
438438
case "slim-window":
439439
openIn = proto.AppOpenIn_SLIM_WINDOW
440-
case "window":
441-
openIn = proto.AppOpenIn_WINDOW
442440
case "tab":
443441
openIn = proto.AppOpenIn_TAB
444442
}

‎provisionersdk/proto/provisioner.pb.go‎

Lines changed: 20 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎provisionersdk/proto/provisioner.proto‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ message Script {
164164
}
165165

166166
enum AppOpenIn {
167-
WINDOW = 0;
167+
WINDOW = 0 [deprecated = true];
168168
SLIM_WINDOW = 1;
169169
TAB = 2;
170170
}

0 commit comments

Comments
 (0)