Skip to content

test: force console tests to operate in tty mode#6846

Merged
galargh merged 2 commits intocheck-failing-test-v-nextfrom
console-tty
Jun 12, 2025
Merged

test: force console tests to operate in tty mode#6846
galargh merged 2 commits intocheck-failing-test-v-nextfrom
console-tty

Conversation

@galargh
Copy link
Copy Markdown
Contributor

@galargh galargh commented Jun 12, 2025

I browsed through the node changelog and I found an even less intrusive fix for our "use after close" issue. In fact, this could probably be considered a full fix unless we expect users to use the console tasks in a nonTTY environments.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 819be18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Backlog in Hardhat Jun 12, 2025
@galargh galargh mentioned this pull request Jun 12, 2025
Merged
@galargh
Copy link
Copy Markdown
Contributor Author

galargh commented Jun 12, 2025 •
edited
Loading

The fix for the failing WASM compilation is inspired by the conversation from nodejs/node#58515 (and more specifically a similar fix that was applied here nodejs/node#58598 (comment) + nodejs/node@4d6f693).

I'm still not sure why we weren't hit by this earlier.

@fvictorio fvictorio mentioned this pull request Jun 12, 2025
Merged
@galargh galargh requested a review from kanej June 12, 2025 12:59
kanej
kanej approved these changes Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for documenting our issues here in the code comment.

@galargh galargh merged commit 38d8b94 into check-failing-test-v-next Jun 12, 2025
161 checks passed
@galargh galargh deleted the console-tty branch June 12, 2025 13:15
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Hardhat Jun 12, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kanej kanej kanej approved these changes

@ChristopherDedominici ChristopherDedominici Awaiting requested review from ChristopherDedominici

Assignees

No one assigned

Labels

None yet

Projects

Hardhat
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@galargh @kanej @nomic-foundation-automation