Skip to content

fix(geolocation): perm handling around wheninuse vs always #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 16 commits into
base: feat/plugin-tools-updates
Choose a base branch
from
Open

fix(geolocation): perm handling around wheninuse vs always #521

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
98af1e3
fix(geolocation): perm handling around wheninuse vs always
NathanWalker Jul 10, 2023
01aaec8
chore: cleanup
NathanWalker Jul 11, 2023
012d280
release(geolocation): 8.2.1
NathanWalker Jul 11, 2023
e27f762
chore: ts-patch 3 - can be removed once plugin-tools contains the update
NathanWalker Jul 12, 2023
6d67da3
feat(localize): support for language codes with 3 characters (#520)
kmahelona Jul 12, 2023
c91f518
release(localize): 5.2.0
NathanWalker Jul 12, 2023
1d157c9
Merge remote-tracking branch 'origin/main' into fix/geolocation
NathanWalker Jul 12, 2023
eb21410
docs(google-signin): Update docs to include adding GIDClientID to inf…
williamjuan027 Jul 14, 2023
565514f
chore: readme
NathanWalker Aug 1, 2023
a55b917
docs(appavailibility): add android permission note (#523)
herefishyfish Aug 4, 2023
b0982b4
fix(google-maps): polygon holes (#526)
Log3n Aug 29, 2023
fbc7fc5
fix(secure-storage): Add Support for Access/Application groups on IOS…
jcassidyav Sep 4, 2023
c39be93
release(secure-storage): 3.0.3
jcassidyav Sep 4, 2023
938d880
feat(imagepicker): consolidate API with improved typings (#530)
jcassidyav Sep 16, 2023
a5924fd
release(imagepicker): 3.0.0
NathanWalker Sep 16, 2023
a3ec765
Merge remote-tracking branch 'origin/main' into fix/geolocation
NathanWalker Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(localize): support for language codes with 3 characters (#520)
  • Loading branch information
@kmahelona
kmahelona authored Jul 12, 2023
commit 6d67da3ac10cfa81f0962d97ec3a7d86ba3c8509
6 changes: 5 additions & 1 deletion packages/localize/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ export function androidLaunchEventLocalizationHandler() {
}

export function overrideLocale(locale: string): boolean {
ApplicationSettings.setString('__app__language__', locale.substring(0, 2));
let language_code = locale.substring(0, 2);
if (locale.indexOf('-') < 0 && locale.length == 3) {
language_code = locale;
}
ApplicationSettings.setString('__app__language__', language_code);
return true;
}
9 changes: 7 additions & 2 deletions packages/localize/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ export function androidLaunchEventLocalizationHandler() {
}

export function overrideLocale(locale: string): boolean {
const path = NSBundle.mainBundle.pathForResourceOfType(locale.substring(0, 2), 'lproj');
let language_code = locale.substring(0, 2);
if (locale.indexOf('-') < 0 && locale.length == 3) {
language_code = locale;
}

const path = NSBundle.mainBundle.pathForResourceOfType(language_code, 'lproj');

if (!path) {
return false;
Expand All @@ -39,7 +44,7 @@ export function overrideLocale(locale: string): boolean {
bundle = NSBundle.bundleWithPath(path);
NSUserDefaults.standardUserDefaults.setObjectForKey([locale], 'AppleLanguages');
NSUserDefaults.standardUserDefaults.synchronize();
ApplicationSettings.setString('__app__language__', locale.substring(0, 2));
ApplicationSettings.setString('__app__language__', language_code);

return true;
}