fix: prevent redundant restarts on rapid changes and recover from app crashes in watch mode#6036
Open
edusperoni wants to merge 1 commit into
Open
fix: prevent redundant restarts on rapid changes and recover from app crashes in watch mode#6036edusperoni wants to merge 1 commit into
edusperoni wants to merge 1 commit into
Conversation
… crashes in watch mode Two issues in the livesync watch loop: 1. Multiple rapid file changes caused each webpack recompilation to trigger a separate sync+restart, even when earlier restarts were already stale. Added exhaustMapWithTrailing semantics: while a sync is in progress, incoming compilation events are coalesced per-platform into a single pending event that runs after the current sync completes. 2. If the app crashed at certain times (e.g. during JS startup), the error handler removed the device from the descriptor list and stopped watchers, permanently killing the watch loop. Fixed by no longer calling stop() on transient sync errors — the device stays in the list and retries on the next file change. Also added .catch() to the promise action chain so a rejected action no longer breaks all subsequent chained actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues in the livesync watch loop:
Multiple rapid file changes caused each webpack recompilation to trigger a separate sync+restart, even when earlier restarts were already stale. Added exhaustMapWithTrailing semantics: while a sync is in progress, incoming compilation events are coalesced per-platform into a single pending event that runs after the current sync completes.
If the app crashed at certain times (e.g. during JS startup), the error handler removed the device from the descriptor list and stopped watchers, permanently killing the watch loop. Fixed by no longer calling stop() on transient sync errors — the device stays in the list and retries on the next file change. Also added .catch() to the promise action chain so a rejected action no longer breaks all subsequent chained actions.