Allow updating target android sdk during "platform add"#183
Merged
teobugslayer merged 1 commit intomasterfrom Jan 16, 2015
Merged
Allow updating target android sdk during "platform add"#183teobugslayer merged 1 commit intomasterfrom
teobugslayer merged 1 commit intomasterfrom
Conversation
|
Test PASSed. |
Contributor
There was a problem hiding this comment.
The return type must be IFuture as you have .wait() in its body.
Contributor
Author
There was a problem hiding this comment.
We shall wait and see (pun intended).
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
Maybe you can use findLast instead of reverse and find
https://lodash.com/docs#findLast
The tns-android template uses by default sdk 17. If the user does not have it installed, we try to update it. To do so safely, we have a white list of well-tested sdks. We match the white list with the installed sdks and take the newest one. This commit depends on https://github.com/telerik/tns-android/commit/990f725d845364e33ca77d4e54212e0c2342bc55 Implements #173
3bfe44e to
76d8967
Compare
Contributor
|
👍 |
|
Test PASSed. |
teobugslayer
added a commit
that referenced
this pull request
Jan 16, 2015
Allow updating target android sdk during "platform add"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tns-android template uses by default sdk 17. If the user does not have it installed, we try to update it.
To do so safely, we have a white list of well-tested sdks. We match the white list with the installed sdks and take the newest one.
This commit depends on https://github.com/telerik/tns-android/commit/990f725d845364e33ca77d4e54212e0c2342bc55
Implements #173