Repository navigation
Routing broken with mixed modal (with inner navigation) and standard routing usages #1484
Description
Make sure to check the existing issues in this repository
If there is no issue for your problem, tell us about it
Routing broken and unreliable after this PR was merged.
Which platform(s) does your issue occur on?
all.
Please, provide the following version numbers that your issue occurs with:
- CLI: 4.2.0
- Cross-platform modules: 4.2.0
- Runtime(s): 4.2.0
Please, tell us how to recreate the issue in as much detail as possible.
Just use an app with routing and modals. Any calls to navigate will eventually become unresponsive/dead and stop navigating.
Is there any code involved?
We'll submit a PR to fix.
Metadata
Metadata
Assignees
Labels
No labels
Activity
NathanWalker commentedon Aug 13, 2018
For anyone who's routing is terribly broken, pin your project to this for now until this is fixed:
"nativescript-angular": "6.1.0-2018-07-03-01",fix(router): navigation unresponsiveness
[-]Routing broken badly[/-][+]Routing broken with mixed modal (with inner navigation) and standard routing usages[/+]NathanWalker commentedon Aug 15, 2018
To clarify this issue is likely related to inner page modal navigation mixed with standard routing usage so if you're app is using both you will likely run into this hence the pinned workaround above. Working on solution here in addition to the pending PR.
NathanWalker commentedon Aug 17, 2018
Here is a repro in playground:
https://play.nativescript.org/?template=play-ng&id=6QPnkI&v=3
• 'navigate to second page'
• tap 'back' button
• now tap 'show modal with frame'
• now tap 'close modal'
• now 'navigate to second page' again
• now tap 'back' button
• routing now dead 💀
/cc @ADjenkov @vakrilov
ADjenkov commentedon Aug 20, 2018
Hey @NathanWalker thanks for the Playground project! Just rename the export name of the home.module.ts ->
export class HomeModule { }in order to be runnable projectNathanWalker commentedon Aug 20, 2018
Ah @ADjenkov linked older version param above there - this was the latest:
https://play.nativescript.org/?template=play-ng&id=6QPnkI&v=11
Thanks for the fix - makes total sense now why it was failing - After that's merged we'll try it with
nexton our projects. 👍