Skip to content

Use cmake-rn #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kraenhansen wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Use cmake-rn #22

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d85889
Add dependency on cmake-rn
Oct 24, 2025
82d0dde
Use CMAKE_OSX_SYSROOT to determine TARGET_PLATFORM
Oct 24, 2025
8d391e2
Refactor build_nativescript.sh to call cmake-rn instead of creating f…
Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use CMAKE_OSX_SYSROOT to determine TARGET_PLATFORM
  • Loading branch information
Kræn Hansen committed Oct 24, 2025
commit 82d0ddea974ed57d017a486a0b702c9e10c3b306
20 changes: 14 additions & 6 deletions NativeScript/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ set(TARGET_ENGINE "v8" CACHE STRING "Target JS engine for the NativeScript runti
set(METADATA_SIZE 0 CACHE STRING "Size of embedded metadata in bytes")
set(BUILD_CLI_BINARY OFF CACHE BOOL "Build the NativeScript CLI binary")

if(CMAKE_OSX_SYSROOT STREQUAL "iphoneos")
set(TARGET_PLATFORM "ios")
elseif(CMAKE_OSX_SYSROOT STREQUAL "iphonesimulator")
set(TARGET_PLATFORM "ios-sim")
elseif(CMAKE_OSX_SYSROOT STREQUAL "macosx")
set(TARGET_PLATFORM "macos")
endif()

if(TARGET_PLATFORM STREQUAL "ios")
set(CMAKE_XCODE_ATTRIBUTE_IPHONEOS_DEPLOYMENT_TARGET "13.0")
set(CMAKE_XCODE_ATTRIBUTE_TARGETED_DEVICE_FAMILY "1,2")
Expand Down Expand Up @@ -305,16 +313,16 @@ if(TARGET_PLATFORM_MACOS)

# Convert the Info.plist from binary format to XML format.
# This seemed to unblock a build error when using in React Native.
add_custom_command(TARGET ${NAME} POST_BUILD
COMMAND plutil -convert xml1 $<TARGET_FILE_DIR:${NAME}>/Resources/Info.plist
)
# add_custom_command(TARGET ${NAME} POST_BUILD
# COMMAND plutil -convert xml1 $<TARGET_FILE_DIR:${NAME}>/Resources/Info.plist
# )
set(METADATA_FILE "metadata.macos.nsmd")
elseif(TARGET_PLATFORM_IOS)
# Convert the Info.plist from binary format to XML format.
# This seemed to unblock a build error when using in React Native.
add_custom_command(TARGET ${NAME} POST_BUILD
COMMAND plutil -convert xml1 $<TARGET_FILE_DIR:${NAME}>/Info.plist
)
# add_custom_command(TARGET ${NAME} POST_BUILD
# COMMAND plutil -convert xml1 $<TARGET_FILE_DIR:${NAME}>/Info.plist
# )

if(TARGET_PLATFORM_SIM)
set(METADATA_FILE "metadata.ios-sim.nsmd")
Expand Down