Skip to content

revert: "fix: prevent crash during debug on fast view churn (like with HMR)" #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edusperoni wants to merge 3 commits into from
Closed

revert: "fix: prevent crash during debug on fast view churn (like with HMR)" #353

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54b34e0
Revert "fix: prevent crash during debug on fast view churn (like with…
edusperoni Apr 3, 2026
0fd0e84
fix: throw JS exception instead of silent warning for disposed native…
Copilot Apr 3, 2026
289ae2a
revert: \"fix: prevent crash during debug on fast view churn (like wi…
Copilot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Revert "fix: prevent crash during debug on fast view churn (like with… 
… HMR) (#…"

This reverts commit 42a5328.
  • Loading branch information
@edusperoni
edusperoni authored Apr 3, 2026
commit 54b34e055297e98222336d4808f9d4f2779eea06
42 changes: 3 additions & 39 deletions NativeScript/runtime/ArgConverter.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
#include <Foundation/Foundation.h>
#include <sstream>
#include <unordered_set>
#include "ArgConverter.h"
#include "NativeScriptException.h"
#include "DictionaryAdapter.h"
#include "ObjectManager.h"
#include "Interop.h"
#include "Helpers.h"
#include "Runtime.h"
#include "RuntimeConfig.h"

using namespace v8;
using namespace std;
Expand All @@ -29,27 +27,7 @@
bool callSuper = false;
if (instanceMethod) {
BaseDataWrapper* wrapper = tns::GetValue(isolate, receiver);

if (wrapper == nullptr) {
// During fast view churn like HMR in development, JS objects can outlive their
// native wrappers briefly. In Debug, avoid a crash and just skip the native call.
// In Release, assert so crash reporting can capture unexpected cases.
if (RuntimeConfig.IsDebug) {
const char* selectorStr = meta ? meta->selectorAsString() : "<unknown>";
const char* jsNameStr = meta ? meta->jsName() : "<unknown>";
const char* classNameStr = klass ? class_getName(klass) : "<unknown>";
// Suppress duplicate logs: only log once per class+selector for this process.
static std::unordered_set<std::string> s_logged;
std::string key = std::string(classNameStr) + ":" + selectorStr;
if (s_logged.insert(key).second) {
Log(@"Note: ignore method on non-native receiver (class: %s, selector: %s, jsName: %s, args: %d). Common during HMR.",
classNameStr, selectorStr, jsNameStr, (int)args.Length());
}
return v8::Undefined(isolate);
} else {
tns::Assert(false, isolate);
}
}
tns::Assert(wrapper != nullptr, isolate);

if (wrapper->Type() == WrapperType::ObjCAllocObject) {
ObjCAllocDataWrapper* allocWrapper = static_cast<ObjCAllocDataWrapper*>(wrapper);
Expand All @@ -65,21 +43,7 @@
// For extended classes we will call the base method
callSuper = isMethodCallback && it != cache->ClassPrototypes.end();
} else {
if (RuntimeConfig.IsDebug) {
const char* selectorStr = meta ? meta->selectorAsString() : "<unknown>";
const char* jsNameStr = meta ? meta->jsName() : "<unknown>";
const char* classNameStr = klass ? class_getName(klass) : "<unknown>";
// Suppress duplicate logs: only log once per class+selector for this process.
static std::unordered_set<std::string> s_logged;
std::string key = std::string(classNameStr) + ":" + selectorStr;
if (s_logged.insert(key).second) {
Log(@"Note: ignore receiver wrapper type %d (class: %s, selector: %s, jsName: %s). Common during HMR.",
(int)wrapper->Type(), classNameStr, selectorStr, jsNameStr);
}
return v8::Undefined(isolate);
} else {
tns::Assert(false, isolate);
}
tns::Assert(false, isolate);
}
}

Expand Down Expand Up @@ -914,7 +878,7 @@
Local<Object> thiz = args.This();
Isolate* isolate = args.GetIsolate();
BaseDataWrapper* wrapper = tns::GetValue(isolate, thiz);
if (wrapper == nullptr || wrapper->Type() != WrapperType::ObjCObject) {
if (wrapper == nullptr && wrapper->Type() != WrapperType::ObjCObject) {
return;
}

Expand Down
Loading