Skip to content

feat: support Vite HMR #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NathanWalker wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

feat: support Vite HMR #161

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
278aeec
feat: support Vite HMR
NathanWalker Dec 27, 2025
dbe2fb9
Merge remote-tracking branch 'origin/main' into feat/vite-hmr
NathanWalker Jan 4, 2026
62613cb
chore: merge main
NathanWalker Jan 4, 2026
277140f
feat: vite hmr wip
NathanWalker Mar 30, 2026
6b34841
chore: re-add zone files
NathanWalker Apr 11, 2026
c98184e
feat(angular): improve vite hmr runtime wiring
NathanWalker Apr 14, 2026
6628560
feat: ensure css applied on hmr http booted realm
NathanWalker Apr 16, 2026
5b56d73
feat: hmr with compiled components and route preservation
NathanWalker Apr 16, 2026
8e8c6c1
feat: hmr applying while keeping route state preserved
NathanWalker Apr 19, 2026
e1ec30d
feat: improve hmr conditions around routing
NathanWalker Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: support Vite HMR
  • Loading branch information
@NathanWalker
NathanWalker committed Dec 27, 2025
commit 278aeec09bf7725dbab8a20fbb4dd654cca953ff
69 changes: 46 additions & 23 deletions packages/angular/src/lib/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,30 +457,53 @@ export function runNativeScriptAngularApp<T, K>(options: AppRunOptions<T, K>) {
if (oldAddEventListener) {
global.NativeScriptGlobals.events.addEventListener = oldAddEventListener;
}
if (import.meta['webpackHot']) {
// handle HMR Application.run
global['__dispose_app_ng_platform__'] = () => {
disposePlatform('hotreload');
};
global['__dispose_app_ng_modules__'] = () => {
disposeLastModules('hotreload');
};
global['__bootstrap_app_ng_modules__'] = () => {
bootstrapRoot('hotreload');
};
global['__cleanup_ng_hot__'] = () => {
Application.off(Application.launchEvent, launchCallback);
Application.off(Application.exitEvent, exitCallback);
disposeLastModules('hotreload');

// Detect HMR environment (webpack or Vite)
const isWebpackHot = !!import.meta['webpackHot'];
const isViteHot = !!import.meta['hot'];
const isHotReloadEnabled = isWebpackHot || isViteHot;

// Always expose HMR globals for both webpack and Vite HMR support
// These allow the HMR runtime to properly dispose and re-bootstrap Angular
global['__dispose_app_ng_platform__'] = () => {
disposePlatform('hotreload');
};
global['__dispose_app_ng_modules__'] = () => {
disposeLastModules('hotreload');
};
global['__bootstrap_app_ng_modules__'] = () => {
bootstrapRoot('hotreload');
};
global['__cleanup_ng_hot__'] = () => {
Application.off(Application.launchEvent, launchCallback);
Application.off(Application.exitEvent, exitCallback);
disposeLastModules('hotreload');
disposePlatform('hotreload');
};
global['__reboot_ng_modules__'] = (shouldDisposePlatform: boolean = false) => {
disposeLastModules('hotreload');
if (shouldDisposePlatform) {
disposePlatform('hotreload');
};
global['__reboot_ng_modules__'] = (shouldDisposePlatform: boolean = false) => {
disposeLastModules('hotreload');
if (shouldDisposePlatform) {
disposePlatform('hotreload');
}
bootstrapRoot('hotreload');
};
}
bootstrapRoot('hotreload');
};

if (isWebpackHot) {
// Webpack-specific HMR handling
import.meta['webpackHot'].decline();

if (!Application.hasLaunched()) {
Application.run();
return;
}
bootstrapRoot('hotreload');
return;
}

if (isViteHot) {
// Vite-specific HMR handling
// Vite HMR is handled by @nativescript/vite's HMR runtime
// which will call __reboot_ng_modules__ when needed

if (!Application.hasLaunched()) {
Application.run();
Expand Down