fix: #8666 #6981 #5054#8670
Merged
Merged
Conversation
Contributor
|
Nice work @dimitrisrk thank you 👍 |
NathanWalker
approved these changes
Jun 24, 2020
NathanWalker
approved these changes
Jun 30, 2020
Contributor
|
Released with https://github.com/NativeScript/NativeScript/releases/tag/6.5.9 now |
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
tarunama
pushed a commit
to tarunama/NativeScript
that referenced
this pull request
Sep 9, 2020
…using an update call (NativeScript#8670) closes NativeScript#8666 closes NativeScript#6981 closes NativeScript#5054
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Reference '$parents' or '$parent' can be undefined when included in expressions that are nested inside a ListView or a Repeater.
Playground Sample: https://play.nativescript.org/?template=play-js&id=TERk3c&v=11
Note: A component sample called 'parents-expression' is included inside ui-tests-app list-view section.
What is the new behavior?
Parent referenced expression-values will be loaded properly using an 'update' call just like core already does with sourceProperties.
Fixes #8666 #7983 #6981 #5054