fix(button-android): use setMinWidth to set TextView widgets min-width#7804
Merged
Conversation
manoldonev
approved these changes
Sep 12, 2019
vakrilov
approved these changes
Dec 12, 2019
fde5cdd to
9b01c59
Compare
Contributor
|
There seems to be a behavior change with this PR. The default min-width of the android buttons is no longer present. Before: After: This has a potential of breaking client apps. @bundyo do you think there is a way to make this back-compatible? |
vakrilov
suggested changes
Jan 14, 2020
vakrilov
left a comment
Contributor
There was a problem hiding this comment.
There seem to be a behavior change detected by the e2e tests.
See #7804 (comment)
Contributor
Author
|
We might introduce a default min-width for the property? |
f45b01d to
e202fb6
Compare
vakrilov
approved these changes
Jan 27, 2020
Contributor
|
test |
73237d2 to
fd2888b
Compare
Contributor
|
test |
fd2888b to
88e7ab6
Compare
* release: cut 6.5.0 release * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
dtopuzov
approved these changes
Mar 26, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
#7804) * fix: setMinimumWidth does not really set the minWidth for TextView widgets * chore: fix versions * refactor(android): default minWidth/Height values for button * reafctor: reset minWidth when view is in flexbox for backcompat * refactor: ensure back-compatible layout for btns * chore: cut 6.5.0 release (#8443) * release: cut 6.5.0 release * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com> Co-authored-by: vakrilov <alexander.vakrilov@telerik.com> Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com> Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Aligned Buttons with short text have a min-width that can't be removed.
What is the new behavior?
Removes the min-width. According to Android docs:
Thus for TextViews as the Button, both should be set.
https://developer.android.com/reference/android/widget/TextView.html#setMinWidth(int)
Fixes/Implements/Closes #7803.