refactor: Enable missing css check and test#7563
Closed
vakrilov wants to merge 9 commits into
Closed
Conversation
95aaa3d to
087671f
Compare
MartoYankov
reviewed
Jul 24, 2019
| @@ -1,5 +1,5 @@ | |||
| // Require globals first so that snapshot takes __extends function. | |||
| require("globals"); | |||
| import "../globals"; | |||
Contributor
There was a problem hiding this comment.
What is difference here? We have this in a lot of doc files in the API reference i believe.
Contributor
Author
There was a problem hiding this comment.
Webpack is strange and creates code for all "import" statements at the start of the module. So all the imports that are after require("globals") actually get executed before it in the generated bundle.
This happens with when modules are linked and TS is compiled by webpack.
Contributor
There was a problem hiding this comment.
Maybe that's the reason we got so many circular refs with the webpack plugin for circular refs. @manoldonev
MartoYankov
approved these changes
Jul 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable missing CSS check and that were disabled in #7499 and #7501