fix(ios-tabs): tabstripitem tap does not change tabs#7468
Merged
Conversation
MartoYankov
approved these changes
Jul 8, 2019
manoldonev
reviewed
Jul 8, 2019
| public tabBarShouldSelectItem(tabBar: MDCTabBar, item: UITabBarItem): boolean { | ||
| return true; | ||
| const owner = this._owner.get(); | ||
| const shouldSelectItem = owner._canSelectItem; |
Contributor
There was a problem hiding this comment.
Check whether owner is not null prior to using it (weak reference)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note 1:
tabBar.delegatewas cleared after some time. Storing it in a local var and clearing on dispose.Note 2: Enable tabStrip items selection only if no current animation in progress.
Fix #7435
Fix -> Changing fast tabStrip items causes glitches and content items problem