feat: add css for tabstripitem for bottom navigation android#7458
Merged
Conversation
Contributor
Author
|
test package_version#rc |
a6f863b to
b514665
Compare
Contributor
Author
|
test package_version#rc |
manoldonev
reviewed
Jul 4, 2019
manoldonev
reviewed
Jul 4, 2019
manoldonev
reviewed
Jul 4, 2019
manoldonev
reviewed
Jul 4, 2019
| if (this.tabStrip && this.tabStrip.items) { | ||
| const tabItems = new Array<org.nativescript.widgets.TabItemSpec>(); | ||
| this.tabStrip.items.forEach((item, i, arr) => { | ||
| (<any>item).index = i; |
Contributor
There was a problem hiding this comment.
Let's at least define it on TabStripItem as public index: number; (like on TabContentItem)
manoldonev
reviewed
Jul 4, 2019
|
|
||
| public setTabBarItemBackgroundColor(tabStripItem: TabStripItem, value: android.graphics.drawable.Drawable | Color): void { | ||
| // TODO: Should figure out a way to do it directly with the the nativeView | ||
| const tabStripItemIndex = this.tabStrip.items.indexOf(tabStripItem); |
Contributor
There was a problem hiding this comment.
You are now setting index on tabStripItem (line 385) -- can't we use it instead?
manoldonev
approved these changes
Jul 5, 2019
Contributor
|
test package_version#rc |
24e34b9 to
8cf8f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.