Skip to content

feat: add background color css to tab strip#7414

Merged
MartoYankov merged 4 commits into
masterfrom
myankov/tab-strip-background
Jun 28, 2019
Merged

feat: add background color css to tab strip#7414
MartoYankov merged 4 commits into
masterfrom
myankov/tab-strip-background

Conversation

@MartoYankov

Copy link
Copy Markdown
Contributor

Effectively enables the following CSS rule-set:

TabStrip {
    background-color: red;
}

@MartoYankov MartoYankov force-pushed the myankov/tab-strip-background branch from ff77eee to ac618bb Compare June 27, 2019 11:39
@manoldonev manoldonev requested a review from ADjenkov June 27, 2019 12:01
@manoldonev

Copy link
Copy Markdown
Contributor

Got the following when switching tabs on Tabs background color example (not reproducible on fresh start -- prior to that I browsed through all BottomNavigation examples):

CONSOLE LOG file:///app/bundle.js:62394:16: ### NativeScriptError: TypeError: undefined is not an object (evaluating 'this._owner.get')
CONSOLE LOG file:///app/bundle.js:62395:16: ### nativeException: undefined
CONSOLE LOG file:///app/bundle.js:62396:16: ### stackTrace: JS: 1   tabBarDidSelectItem@file:///app/Users/mdonev/github/NativeScript/tns-core-modules/ui/tabs/tabs.ts:45:34
2   UIApplicationMain@[native code]
3   _start@file:///app/Users/mdonev/github/NativeScript/tns-core-modules/application/application.ts:321:26
4   @file:///app/bundle.js:62406:68
5   ./app.ts@file:///app/bundle.js:62412:34
6   __webpack_require__@file:///app/webpack/bootstrap:750:0
7   checkDeferredModules@file:///app/webpack/bootstrap:43:0
8   webpackJsonpCallback@file:///app/webpack/bootstrap:30:0
9   anonymous@file:///app/bundle.js:2:61
10  evaluate@[native code]
11  moduleEvaluation@[native code]
12  promiseReactionJob@[native code]
Native:1   NativeScript::FFICallback<NativeScript::ObjCMethodCallback>::ffiClosureCallback(ffi_cif*, void*, void**, void*)@[native code]
2   ffi_closure_unix64_inner@[native code]
3   ffi_closure_unix64@[native code]
4   -[MDCItemBar collectionView:didSelectItemAtIndexPath:]@[native code]
5   -[UICollectionView _selectItemAtIndexPath:animated:scrollPosition:notifyDelegate:]@[native code]
6   -[UICollectionView touchesEnded:withEvent:<…>
CONSOLE LOG file:///app/bundle.js:62397:16: ### stack: tabBarDidSelectItem@file:///app/Users/mdonev/github/NativeScript/tns-core-modules/ui/tabs/tabs.ts:45:34
UIApplicationMain@[native code]
_start@file:///app/Users/mdonev/github/NativeScript/tns-core-modules/application/application.ts:321:26
file:///app/bundle.js:62406:68
./app.ts@file:///app/bundle.js:62412:34
__webpack_require__@file:///app/webpack/bootstrap:750:0
checkDeferredModules@file:///app/webpack/bootstrap:43:0
webpackJsonpCallback@file:///app/webpack/bootstrap:30:0
anonymous@file:///app/bundle.js:2:61
evaluate@[native code]
moduleEvaluation@[native code]
promiseReactionJob@[native code]
CONSOLE WARN file:///app/app.ts:53:16 undefined is not an object (evaluating 'this._owner.get')
***** Fatal JavaScript exception - application has been terminated. *****
Native stack trace:
1   0x10f81621f NativeScript::reportFatalErrorBeforeShutdown(JSC::ExecState*, JSC::Exception*, bool)
2   0x10f84e460 NativeScript::FFICallback<NativeScript::ObjCMethodCallback>::ffiClosureCallback(ffi_cif*, void*, void**, void*)
3   0x1101eef36 ffi_closure_unix64_inner
4   0x1101ef95a ffi_closure_unix64
5   0x111943158 -[MDCItemBar collectionView:didSelectItemAtIndexPath:]
6   0x113822412 -[UICollectionView _selectItemAtIndexPath:animated:scrollPosition:notifyDelegate:]
7   0x11384cd89 -[UICollectionView touchesEnded:withEvent:]
8   0x113fdaa09 forwardTouchMethod
9   0x113fdaad8 -[UIResponder touchesEnded:withEvent:]
10  0x113fdaa09 forwardTouchMethod
11  0x113fdaad8 -[UIResponder touchesEnded:withEvent:]
12  0x113b929c9 _UIGestureEnvironmentUpdate
13  0x113b90108 -[UIGestureEnvironment _deliverEvent:toGestureRecognizers:usingBlock:]
14  0x113b8fe96 -[UIGestureEnvironment _updateForEvent:window:]
15  0x113feb5bc -[UIWindow sendEvent:]
16  0x113fc9d16 -[UIApplication sendEvent:]
17  0x11409a293 __dispatchPreprocessedEventFromEventQueue
18  0x11409cbb9 __handleEventQueueInternal
19  0x112ad0be1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
20  0x112ad0463 __CFRunLoopDoSources0
21  0x112acab1f __CFRunLoopRun
22  0x112aca302 CFRunLoopRunSpecific
23  0x119b532fe GSEventRunModal
24  0x113fafba2 UIApplicationMain
25  0x1101ef79d ffi_call_unix64
26  0x1281128e0
JavaScript stack trace:
1   tabBarDidSelectItem@file:///app/Users/mdonev/github/NativeScript/tns-core-modules/ui/tabs/tabs.ts:45:34
2   UIApplicationMain@[native code]
3   _start@file:///app/Users/mdonev/github/NativeScript/tns-core-modules/application/application.ts:321:26
4   @file:///app/bundle.js:62406:68
5   ./app.ts@file:///app/bundle.js:62412:34
6   __webpack_require__@file:///app/webpack/bootstrap:750:0
7   checkDeferredModules@file:///app/webpack/bootstrap:43:0
8   webpackJsonpCallback@file:///app/webpack/bootstrap:30:0
9   anonymous@file:///app/bundle.js:2:61
10  evaluate@[native code]
11  moduleEvaluation@[native code]
12  promiseReactionJob@[native code]
JavaScript error:
file:///app/Users/mdonev/github/NativeScript/tns-core-modules/ui/tabs/tabs.ts:45:34 JS ERROR TypeError: undefined is not an object (evaluating 'this._owner.get')

@manoldonev manoldonev force-pushed the myankov/tab-strip-background branch from 372135b to 9fab8f6 Compare June 27, 2019 12:57
@MartoYankov MartoYankov merged commit 4353450 into master Jun 28, 2019
@MartoYankov MartoYankov deleted the myankov/tab-strip-background branch June 28, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants