Skip to content

test(safe-area): fix ios 12 landscape tests#6434

Merged
MartoYankov merged 2 commits into
masterfrom
myankov/fix-landscape-tests
Oct 19, 2018
Merged

test(safe-area): fix ios 12 landscape tests#6434
MartoYankov merged 2 commits into
masterfrom
myankov/fix-landscape-tests

Conversation

@MartoYankov

Copy link
Copy Markdown
Contributor
  • Add longer text for WrapLayout tests, so that the setup is the same in landscape
  • Add wait until actual ios modal is closed. This should be a temp fix for unit tests.
  • Add greaterOrCloseEnough assert method similar to lessOrCloseEnough, so that landscape cases are covered.

@MartoYankov MartoYankov self-assigned this Oct 19, 2018
@MartoYankov MartoYankov requested a review from vchimev October 19, 2018 12:32
@ghost ghost added the in progress label Oct 19, 2018
@MartoYankov

Copy link
Copy Markdown
Contributor Author

test --ignore ios12

@SvetoslavTsenov

Copy link
Copy Markdown
Contributor

test --ignore ios12

@SvetoslavTsenov

Copy link
Copy Markdown
Contributor

test --ignore ios12 tns_core_modules_unit_tests ios11

@SvetoslavTsenov

Copy link
Copy Markdown
Contributor

build_tns_core_modules_unit_tests
test --ignore ios12 tns_core_modules_unit_tests build_tns_core_modules_unit_tests ios11

@SvetoslavTsenov

Copy link
Copy Markdown
Contributor

test --ignore ios12 tns_core_modules_unit_tests build_tns_core_modules_unit_tests ios11

@SvetoslavTsenov

Copy link
Copy Markdown
Contributor

test --ignore ios12 ios11

@MartoYankov

Copy link
Copy Markdown
Contributor Author

test ios12

@SvetoslavTsenov

Copy link
Copy Markdown
Contributor

test --ignore ios12 tns_core_modules_unit_tests xcode10

@MartoYankov MartoYankov merged commit a211bbd into master Oct 19, 2018
@MartoYankov MartoYankov deleted the myankov/fix-landscape-tests branch October 19, 2018 15:48
@ghost ghost removed the in progress label Oct 19, 2018
@lock

lock Bot commented Oct 19, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants