Skip to content

fix(android): second livesync #6330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manoldonev merged 2 commits into from
Oct 4, 2018
Merged

fix(android): second livesync #6330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c17929b
fix(android): second livesync
manoldonev Oct 1, 2018
75ec4fc
Merge branch 'master' into mdonev/livesync-fix
manoldonev Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions tns-core-modules/ui/frame/fragment.transitions.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,15 +721,6 @@ function toShortString(nativeTransition: android.transition.Transition): string
return `${nativeTransition.getClass().getSimpleName()}@${nativeTransition.hashCode().toString(16)}`;
}

function createDummyZeroDurationAnimation(): android.view.animation.Animation {
// NOTE: returning the dummy AlphaAnimation directly does not work for some reason;
// animationEnd is fired first, then some animationStart (but for a different animation?)
const animationSet = new android.view.animation.AnimationSet(false);
animationSet.addAnimation(new android.view.animation.AlphaAnimation(1, 1));

return animationSet;
}

function printTransitions(entry: ExpandedEntry) {
if (entry && traceEnabled()) {
let result = `${entry.fragmentTag} Transitions:`;
Expand All @@ -756,6 +747,14 @@ function printTransitions(entry: ExpandedEntry) {

class NoTransition extends Transition {
public createAndroidAnimation(transitionType: string): android.view.animation.Animation {
return createDummyZeroDurationAnimation();
const animation = new android.view.animation.AlphaAnimation(1, 1);
// NOTE: this should not be necessary when we revert to Animators API
// HACK: Android view animation with zero duration seems to be buggy and raises animation listener events in illogical (wrong?) order:
// "enter" start -> "enter" end -> "exit" start -> "exit" end;
// we would expect events to overlap "exit" start -> "enter" start -> "exit" end -> "enter" end, or at least
// "exit" start / end to be raised before "enter" start / end
animation.setDuration(1);

return animation;
}
}