Repository navigation
Fix: IOS text view hint should never show while editing - #4292
Merged
Merged
Conversation
hshristov
reviewed
Jun 1, 2017
| private _ios: UITextView; | ||
| private _delegate: UITextViewDelegateImpl; | ||
| private _isShowingHint: boolean; | ||
| public _isEditing: boolean = false; |
Contributor
There was a problem hiding this comment.
It is possible to leave it without value (it will be falsy by default)
hshristov
approved these changes
Jun 1, 2017
vakrilov
force-pushed
the
fix-ios-text-view-hint
branch
from
June 1, 2017 09:23
1ae918f to
4509f04
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3354
UI test added as this involves keyboard focus. Steps to reproduce in ui-tests-app:
issues->3354-iosclearbutton.Expected result: The focus remains inside the text-view, but the text is cleared.
Result before the fix: The focus remains inside the text-view, however the hint text is shown instead.
cc: @SvetoslavTsenov @vchimev