Skip to content

fix(animations): remove default getters for tranform properties #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sis0k0 merged 1 commit into from
May 29, 2017
Merged

fix(animations): remove default getters for tranform properties #4286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions tns-core-modules/ui/core/view/view.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,37 +394,22 @@ export class View extends ViewCommon {
}
}

[rotateProperty.getDefault](): number {
return org.nativescript.widgets.ViewHelper.getRotate(this.nativeView);
}
[rotateProperty.setNative](value: number) {
org.nativescript.widgets.ViewHelper.setRotate(this.nativeView, float(value));
}

[scaleXProperty.getDefault](): number {
return org.nativescript.widgets.ViewHelper.getScaleX(this.nativeView);
}
[scaleXProperty.setNative](value: number) {
org.nativescript.widgets.ViewHelper.setScaleX(this.nativeView, float(value));
}

[scaleYProperty.getDefault](): number {
return org.nativescript.widgets.ViewHelper.getScaleY(this.nativeView);
}
[scaleYProperty.setNative](value: number) {
org.nativescript.widgets.ViewHelper.setScaleY(this.nativeView, float(value));
}

[translateXProperty.getDefault](): dip {
return layout.toDeviceIndependentPixels(org.nativescript.widgets.ViewHelper.getTranslateX(this.nativeView));
}
[translateXProperty.setNative](value: dip) {
org.nativescript.widgets.ViewHelper.setTranslateX(this.nativeView, layout.toDevicePixels(value));
}

[translateYProperty.getDefault](): dip {
return layout.toDeviceIndependentPixels(org.nativescript.widgets.ViewHelper.getTranslateY(this.nativeView));
}
[translateYProperty.setNative](value: dip) {
org.nativescript.widgets.ViewHelper.setTranslateY(this.nativeView, layout.toDevicePixels(value));
}
Expand All @@ -434,10 +419,6 @@ export class View extends ViewCommon {
}
[zIndexProperty.setNative](value: number) {
org.nativescript.widgets.ViewHelper.setZIndex(this.nativeView, value);
// let nativeView = this.nativeView;
// if (nativeView instanceof android.widget.Button) {
// nativeView.setStateListAnimator(null);
// }
}

[backgroundInternalProperty.getDefault](): android.graphics.drawable.Drawable {
Expand Down