Skip to content

Revert the translateX/Y to be in dip, Length prefer number to object type#4056

Merged
PanayotCankov merged 1 commit intomasterfrom
revert-translate
Apr 25, 2017
Merged

Revert the translateX/Y to be in dip, Length prefer number to object type#4056
PanayotCankov merged 1 commit intomasterfrom
revert-translate

Conversation

@PanayotCankov
Copy link
Copy Markdown
Contributor

@PanayotCankov PanayotCankov commented Apr 24, 2017 •
edited
Loading

  • Lengths will now prefer to result in dip number rather than { unit: "dip", value: } to make general computations with the stored dip easier.
  • translateX/translateY will be no longer in Length, now it is in dip
  • Aliased number with px, dip and percent types to indicate the expected units in several APIs.

@PanayotCankov PanayotCankov changed the title Revert the translateX/Y to be in dip Revert the translateX/Y to be in dip, Length prefer number to object type Apr 24, 2017
@PanayotCankov PanayotCankov reopened this Apr 24, 2017
@PanayotCankov PanayotCankov merged commit 826c922 into master Apr 25, 2017
@PanayotCankov PanayotCankov deleted the revert-translate branch April 25, 2017 13:02
@lock
Copy link
Copy Markdown

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@vakrilov vakrilov vakrilov approved these changes

@hshristov hshristov hshristov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PanayotCankov @vakrilov @hshristov @ns-bot