Repository navigation
Conversation
…parsed A shorthand registered after the app CSS was parsed stayed unexpanded, so every view re-ran its converter on each apply and the cascade mixed it with longhands. Rules now expand it once, on first use.
|
View your CI Pipeline Execution ↗ for commit 05f6c7d
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shorthands are expanded into longhands while the CSS is parsed. One registered later (a plugin, or core's own
flex/flex-flow, which load withFlexboxLayout) stayed unexpanded:Each rule now expands late shorthands once, on first use. A registration counter keeps the per-view cost to one integer compare. Rules without late shorthands are unchanged.
Tests: 3 new specs in
css-selector.spec.ts; core suite passes.