feat(core): swiftui lifecycle boot apps to use standard notification observers for windows - #11345
Open
NathanWalker wants to merge 1 commit into
Open
feat(core): swiftui lifecycle boot apps to use standard notification observers for windows#11345NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
NathanWalker
commented
Aug 2, 2026
Contributor
- Proven more reliable than .onReceive, particularly when main window reconstructs in different use cases
|
View your CI Pipeline Execution ↗ for commit d715894
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
NathanWalker
force-pushed
the
feat/swiftui-lifecycle-window-observers
branch
3 times, most recently
from
August 3, 2026 19:35
4218c94 to
d715894
Compare
…observers for windows Replace the process-global flag and discarded observer tokens with NativeScriptWindowCommandCoordinator, which owns the NotificationCenter tokens and registers them once per process. The SwiftUI environment actions (openWindow, dismissWindow, openImmersiveSpace, dismissImmersiveSpace) are rebound on every appearance so commands always dispatch through actions from the current scene rather than ones captured at first launch. Documents the boot-ordering guarantee that observers are installed before the JS runtime can post its first window command, and deletes the unused force-cast parseWindowInfo in favor of a single optional-safe parser.
NathanWalker
force-pushed
the
feat/swiftui-lifecycle-window-observers
branch
from
August 3, 2026 19:52
d715894 to
b3ca006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.