fix(ios): guard safe-area helpers against detached NS subtrees - #11325
Open
NathanWalker wants to merge 1 commit into
Open
fix(ios): guard safe-area helpers against detached NS subtrees#11325NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
Views attached to UIKit but without an NS parent (e.g. a view passed to TabView's `iosBottomAccessory`, hosted in UITabAccessory.contentView) have no viewController/scrollView ancestor to derive safe-area bounds from. Guard IOSHelper.getAvailableSpaceFromParent against a null parent and have expandBeyondSafeArea return the frame as-is when no reference rect exists, instead of crashing the layout pass.
|
View your CI Pipeline Execution ↗ for commit 3a79266
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Views attached to UIKit but without an NS parent (e.g. a view passed to TabView's
iosBottomAccessory, hosted in UITabAccessory.contentView) have no viewController/scrollView ancestor to derive safe-area bounds from. Guard IOSHelper.getAvailableSpaceFromParent against a null parent and have expandBeyondSafeArea return the frame as-is when no reference rect exists, instead of crashing the layout pass.