feat(ios): shared transition improvements - #11322
Open
NathanWalker wants to merge 1 commit into
Open
Conversation
NathanWalker
commented
Aug 1, 2026
Contributor
- refined presentation/dismissal positioning and TabView integration.
- improved property animations for shared transitions; smoother property matching between shared elements during page transitions.
- shadows with shared transitions; shadow support carried through shared element snapshots across present/dismiss
NathanWalker
force-pushed
the
feat/shared-transitions-improvements
branch
from
August 1, 2026 17:35
88f17dc to
95ec3b9
Compare
|
View your CI Pipeline Execution ↗ for commit e78c048
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Combines three passes of shared transition work: - feat: improve shared transitions — refined presentation/dismissal positioning and TabView integration. - feat(core): improved property animations for shared transitions — smoother property matching between shared elements during page transitions. - feat(core): shadows with shared transitions — shadow support carried through shared element snapshots across present/dismiss (iOS, with Android helper stubs).
NathanWalker
force-pushed
the
feat/shared-transitions-improvements
branch
from
August 3, 2026 20:48
95ec3b9 to
e78c048
Compare
farfromrefug
reviewed
Aug 4, 2026
| * - Pass an object to customize any field. | ||
| * - Omit / `false` to skip. | ||
| */ | ||
| shadow?: boolean | SharedTransitionInteractiveDismissShadow; |
Collaborator
There was a problem hiding this comment.
It should be named with ios if it is ios only
| // from a page via the NS view tree, but whose tagged views should still participate | ||
| // in shared transitions. Registered by their owning component; queried alongside | ||
| // the source page in getSharedElements. | ||
| let externalRoots: Array<ViewBase>; |
Collaborator
There was a problem hiding this comment.
Shouldn't they be weakref?
Collaborator
|
Description on these PRs should be much more detailed explaining what changed. Especially when written by ai. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.