feat(core): flexbox css gutters support#11310
Open
CatchABus wants to merge 7 commits into
Open
Conversation
|
View your CI Pipeline Execution ↗ for commit abbe783
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
CatchABus
marked this pull request as ready for review
July 21, 2026 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now, flex and grid layouts are missing support for gap properties.
What is the new behavior?
This PR uses the existing flexboxlayout lib dividers as a basis and adds support for flex gutters.
More specifically:
Properties support the de facto px and dip units for now and can be tested using the
gutterssample in toolbox application.Additionally, the PR includes google/flexbox-layout#111 and google/flexbox-layout#267 as improvements.
Note: The PR removes all the unused divider implementation remnants in favor of css gap since it didn't align with css props as a feature.