feat(TextBase): localized text transform#11302
Open
CatchABus wants to merge 4 commits into
Open
Conversation
|
View your CI Pipeline Execution ↗ for commit ccf2cf7
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now, CSS
text-transformproperty does not respect locale.This results in incorrect text casing for languages other than English.
What is the new behavior?
CSS
text-transformproperty will respect current locale (can be changed using native apis).This PR also contains a new and accurate capitalization function to ensure
capitalizeis identical in both platforms (inspired by Apache WordUtils.capitalize).Users can also use
@nativescript/localizeor@nativescript-community/lplugins to switch locale to one of their own andtext-transformwill respect that.For
@nativescript/localize, useoverrideLocaleandandroidLaunchEventLocalizationHandlerfunctions.For
@nativescript-community/l, useoverrideNativeLocalefunction.