fix(core): prevent exponential traversal in _dialogClosed and _onRootViewReset#11220
Merged
Conversation
…ViewReset Both methods used eachDescendant to walk the full subtree, then each visited child recursively called the same method—which walked its own subtree again. For a tree of depth n this produced O(2^n) visits. Replace eachDescendant with eachChild so each node is visited exactly once via natural recursion, reducing traversal to O(n).
|
View your CI Pipeline Execution ↗ for commit d7a49a4
☁️ Nx Cloud last updated this comment at |
NathanWalker
approved these changes
May 19, 2026
Ari4ka
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Both methods used eachDescendant to walk the full subtree, then each visited child recursively called the same method—which walked its own subtree again. For a tree of depth n this produced O(2^n) visits.
What is the new behavior?
Replace eachDescendant with eachChild so each node is visited exactly once via natural recursion, reducing traversal to O(n).